Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fullscreen issue #870

Merged
merged 2 commits into from
Jan 2, 2020
Merged

Fix fullscreen issue #870

merged 2 commits into from
Jan 2, 2020

Conversation

di72nn
Copy link
Member

@di72nn di72nn commented Nov 12, 2019

Fixes #869.

getSupportActionBar() was called too early in the init.

Also corrected ActionBar handling while switching to fullscreen videos.

@di72nn
Fix theme not being correctly applied with fullscreen view
e65afdf 
Apparently `getSupportActionBar()` shouldn't be called that early.
@di72nn
Ignore ActionBar when switching to fullscreen videos
ff419ba 
...while article view is in fullscreen.
@tcitworld tcitworld added this to the 2.3.1 milestone Nov 12, 2019
@tcitworld tcitworld self-requested a review November 12, 2019 15:56
@Strubbl
Copy link
Contributor

Strubbl commented Jan 2, 2020

I can confirm, the bug is fixed with this commit. --> @tcitworld So i am merging this PR now.

@Strubbl Strubbl merged commit 4afcfbe into master Jan 2, 2020
@Strubbl Strubbl deleted the fix_fullscreen_issue branch January 2, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strubbl Strubbl Strubbl approved these changes

@tcitworld tcitworld Awaiting requested review from tcitworld

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

Wrong background color in dark theme
3 participants
@di72nn @Strubbl @tcitworld